Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rapid to 2.5.x from 2.4.x #6705

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update Rapid to 2.5.x from 2.4.x #6705

wants to merge 1 commit into from

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jan 21, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Describe this PR

Update Rapid from 2.4.x to 2.5.x

Review Guide

  1. Spin up a TM instance
  2. Set up a project where Rapid is an available editor
  3. Edit a task using Rapid
  4. Check that edits are saved to OSM
  5. Check that the area is as expected from the task page
  6. Ensure that the task cannot be marked as completed/not completed/etc while there are unsaved edits

Note: depends upon #6707 due to needing a nodejs version bump

@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend labels Jan 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tsmock
Copy link
Contributor Author

tsmock commented Jan 22, 2025

This depends upon #6707.

@royallsilwallz royallsilwallz self-requested a review January 28, 2025 04:44
@manjitapandey
Copy link

manjitapandey commented Feb 7, 2025 •
edited
Loading

Hi @tsmock, we have deployed and are testing this PR on tm.naxa.com.np.
I encountered an issue of task boundary not being visible on rapid page.

Steps to reproduce:

  1. Create a project with rapid editor enabled for mapping and validation
  2. Go to tasks page and choose rapid as editor and map selected tasks.
  3. Refresh the page on rapid editor UI
  4. See the task boundary (which used to be on blue colour) isn't there.

image

Can you please verify and fix the issue so that we can proceed further with the PR.
cc: @royallsilwallz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royallsilwallz royallsilwallz Awaiting requested review from royallsilwallz

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsmock @manjitapandey